Fix: Topics module of V7.9.0.3.2e, sql syntax error

Nuke Soldier Joined: Jan 17, 2006 Posts: 12

I found a bug in the Topics module with MySQL5. It didnt show the topics.
Reason was the mysql5 keyword "reads", used as varname in the query.
By that, the query failed and returned 0 rows, so no topics were shown.

Fix:
(line numbers are from PHPNuke7.9.0.3.2e)

---
OPEN FILE: modules/Topics/index.php

FIND: (line 28)

Code:

$sql = "SELECT t.topicid, t.topicimage, t.topictext, count(s.sid) AS stories, SUM(s.counter) AS reads FROM ".$prefix."_topics t LEFT JOIN ".$prefix."_stories s ON (s.topic = t.topicid) GROUP BY t.topicid, t.topicimage, t.topictext ORDER BY t.topictext";

REPLACE WITH:

Code:

$sql = "SELECT t.topicid, t.topicimage, t.topictext, count(s.sid) AS stories, SUM(s.counter) AS thereads FROM ".$prefix."_topics t LEFT JOIN ".$prefix."_stories s ON (s.topic = t.topicid) GROUP BY t.topicid, t.topicimage, t.topictext ORDER BY t.topictext";

FIND: (line 55)

Code:

$output .= "<big>·</big> "._TOTREADS.": ".(isset($row['reads']) ? $row['reads'] : 0)."";

REPLACE WITH:

Code:

$output .= "<big>·</big> "._TOTREADS.": ".(isset($row['thereads']) ? $row['thereads'] : 0)."";

SAVE FILE: modules/Topics/index.php
DONE
---