Surveys Block Speed...

Private Joined: Aug 08, 2003 Posts: 43

I know that their are performance issues with the Surveys block and the ammount of querys it puts on the database. Does anyone know a fix for this, or code that I can patch to lessen the strain on the server?

Posted: Tue Sep 28, 2004 8:12 am

ryanrbftp wrote:

I know that their are performance issues with the Surveys block and the ammount of querys it puts on the database. Does anyone know a fix for this, or code that I can patch to lessen the strain on the server?

For example, in block, you can make next thing

Code:

//onchange1
$result_z=$db->sql_query("SELECT pollID, optionText, optionCount, voteID FROM ".$prefix."_poll_data WHERE pollID='$pollID' order by voteID ");
while($row3 = $db->sql_fetchrow($result_z)) {
      $optionText = $row3['optionText'];
   if ($optionText != "") {
   $content .= "<tr><td valign=\"top\"><input type=\"radio\" name=\"voteID\" value=\"".$i."\"></td><td width=\"100%\"><font class=\"content\">$optionText</font></td></tr>\n";
   }
}
//onchange2
/*
for($i = 1; $i <= 12; $i++) {
$row3 = $db->sql_fetchrow($db->sql_query("SELECT pollID, optionText, optionCount, voteID FROM ".$prefix."_poll_data WHERE (pollID='$pollID') AND (voteID='$i')"));
if(isset($row3)) {
   $optionText = $row3['optionText'];
   if ($optionText != "") {
   $content .= "<tr><td valign=\"top\"><input type=\"radio\" name=\"voteID\" value=\"".$i."\"></td><td width=\"100%\"><font class=\"content\">$optionText</font></td></tr>\n";
   }
}
}
*/

You see higher commented lines, these lines you have to find and comment. And insert right higher these lines the code which here writen higher that lines. It'll save a lot of queries.
It's one part of our optimized php-nuke which working great:-)

another option, you can get very good survey script at www.eklon.com , called Opros

Private Joined: Aug 08, 2003 Posts: 43

I can't seem to find the "onchange" you mentioned. Here is my surveys block code:

Code:

<?php

/************************************************************************/
/* PHP-NUKE: Web Portal System */
/* =========================== */
/* */
/* Copyright (c) 2002 by Francisco Burzi */
/* http://phpnuke.org */
/* */
/* This program is free software. You can redistribute it and/or modify */
/* it under the terms of the GNU General Public License as published by */
/* the Free Software Foundation; either version 2 of the License. */
/************************************************************************/

if (eregi("block-Survey.php", $_SERVER['PHP_SELF'])) {
Header("Location: index.php");
die();
}

global $prefix, $multilingual, $currentlang, $db, $boxTitle, $content, $pollcomm, $user, $cookie;

if ($multilingual == 1) {
$querylang = "WHERE planguage='$currentlang' AND artid='0'";
} else {
$querylang = "WHERE artid='0'";
}

$sql = "SELECT pollID FROM ".$prefix."_poll_desc $querylang ORDER BY pollID DESC LIMIT 1";
$result = $db->sql_query($sql);
$row = $db->sql_fetchrow($result);
$pollID = $row[pollID];
if ($pollID == 0 || $pollID == "") {
$content = "";
} else {
if(!isset($url))
$url = sprintf("modules.php?name=Surveys&op=results&pollID=%d", $pollID);
$content .= "<form action=\"modules.php?name=Surveys\" method=\"post\">";
$content .= "<input type=\"hidden\" name=\"pollID\" value=\"".$pollID."\">";
$content .= "<input type=\"hidden\" name=\"forwarder\" value=\"".$url."\">";
$sql2 = "SELECT pollTitle, voters FROM ".$prefix."_poll_desc WHERE pollID=$pollID";
$result2 = $db->sql_query($sql2);
$row2 = $db->sql_fetchrow($result2);
$pollTitle = $row2[pollTitle];
$voters = $row2[voters];
$boxTitle = _SURVEY;
$content .= "<font class=\"content\"><b>$pollTitle</b></font><br><br>\n";
$content .= "<table border=\"0\" width=\"100%\">";
for($i = 1; $i <= 12; $i++) {
$sql3 = "SELECT pollID, optionText, optionCount, voteID FROM ".$prefix."_poll_data WHERE (pollID=$pollID) AND (voteID=$i)";
$result3 = $db->sql_query($sql3);
$row3 = $db->sql_fetchrow($result3);
if(isset($row3)) {
   $optionText = $row3[optionText];
   if ($optionText != "") {
   $content .= "<tr><td valign=\"top\"><input type=\"radio\" name=\"voteID\" value=\"".$i."\"></td><td width=\"100%\"><font class=\"content\">$optionText</font></td></tr>\n";
   }
}
}
$content .= "</table><br><center><font class=\"content\"><input type=\"submit\" value=\""._VOTE."\"></font><br>";
if (is_user($user)) {
cookiedecode($user);
}
for($i = 0; $i < 12; $i++) {
$sql4 = "SELECT optionCount FROM ".$prefix."_poll_data WHERE (pollID=$pollID) AND (voteID=$i)";
$result4 = $db->sql_query($sql4);
$row4 = $db->sql_fetchrow($result4);
$optionCount = $row4[optionCount];
$sum = (int)$sum+$optionCount;
}
$content .= "<br><font class=\"content\"><a href=\"modules.php?name=Surveys&op=results&pollID=$pollID&mode=$cookie[4]&order=$cookie[5]&thold=$cookie[6]\"><b>"._RESULTS."</b></a><br><a href=\"modules.php?name=Surveys\"><b>"._POLLS."</b></a><br>";

if ($pollcomm) {
$numcom = $db->sql_numrows($db->sql_query("SELECT * FROM ".$prefix."_pollcomments WHERE pollID='$pollID'"));
$content .= "<br>"._VOTES.": <b>$sum</b> <br> "._PCOMMENTS." <b>$numcom</b>\n\n";
} else {
$content .= "<br>"._VOTES." <b>$sum</b>\n\n";
}
$content .= "</font></center></form>\n\n";
}

?>

Could you paste a modified version of this back so I can copy the whole thing into?