[Bug Fix]CheckEmail Function for Recommend_Us Module

Posted: Sat Jan 10, 2004 10:43 am

If you have a web server where you have catch-all emails setup, You may find this modification (bug fix) useful.

What this fix does: It adds a check email address function to the Recommend_Us module of your PhpNuke website.

Examples of the problems:

[b]- User recommends your site using an invalid email address for the Your Friend part such as www.user@domain.com, user@www.domain.com,
phpNuke will let the user know that his/her suggestion has been sent, but it actually hasn't. Meanwhile, your mail system to return an invalid email to your catch-all account.

Apply this fix and the user is returned a specific error message based on thier invalid formatted email address.

In the file index.php from /modules/Recommend_Us directory, insert the following lines at line 26(approx.)

Code:

function emailCheck($fmail) {
global $stop;
$item = explode("@", $fmail);
$domain = $item["1"];
if ((strlen($domain) >= 3) && (substr($domain, 0, 4) == 'www.')) $stop = "<center>ERROR: Please remove the www. from the domain section of your email address.</center>";
if ((strlen($fmail) >= 4) && (substr($fmail, 0, 4) == 'www.')) $stop = "<center>ERROR: Email addresses do not start with www.</center> ";
if ((!$fmail) || ($fmail=="") || (!eregi("^[_\.0-9a-z-]+@([0-9a-z][0-9a-z-]+\.)+[a-z]{2,6}$",$fmail))) $stop = "<center>ERROR: Invalid email address.</center> ";
if (strrpos($fmail,' ') > 0) $stop = "<center>Please remove spaces from email address.</center> ";
return($stop);
}

In the function SendSite, Find the following lines (approx line 68)...

Code:

mail($fmail, $subject, $message, "From: \"$yname\" <$ymail>\nX-Mailer: PHP/" . phpversion());
update_points(3);
Header("Location: modules.php?name=$module_name&op=SiteSent&fname=$fname");

And change to the following....

Code:

emailCheck($fmail);
if ($stop) {
include("header.php");
OpenTable();
echo "<center>Input Error! ";
echo "$stop "._GOBACK."</center>";
CloseTable();
include("footer.php");
} else {
mail($fmail, $subject, $message, "From: \"$yname\" <$ymail>\nX-Mailer: PHP/" . phpversion());
update_points(3);
Header("Location: modules.php?name=$module_name&op=SiteSent&fname=$fname");
}

Hope this helps for some of you who have the same setup as I do.

Sergeant Joined: Dec 19, 2003 Posts: 105

I suggest you read the RFC on email addresses because your fix here is filtering out valid ones and entering a new bug of your own. The two you cite as being invalid are actually in a correct format per the RFC. The regular expression you're using accounts for only a subset of allowable address formats.

This fix will not prevent bounce backs. It will only make sure the person entered a certain format. To prevent bounce backs it's better to make a connection to determine the address' validity.

Posted: Sat Jan 10, 2004 4:20 pm

From what I have read at http://www.w3.org/Protocols/rfc822/rfc822.txt

You are correct as far as domains and subdomains. Most emails will still deliver if you address to user@www.domain.com but the www. is not required in the address.

As fas as using an address such as www.user@domain.com. I have found that systems such as Yahoo, AOL, and Hotmail do not accept emails with such a format. I am guessing that unless a user registers his account as "www.username" then the system will not accept the email and instead return an error. This is exactly what I have been encountering. A large majority of the users which visit my site have email accounts at AOL, Hotmail, and Yahoo. A lot of email providers follow the same rules.

If you can, please provide quotes or additional information. I would appreciate it.

Sergeant Joined: Jun 13, 2003 Posts: 98

or you could just do a reverse DNS lookup on the domain of the email address. if it doesn't return "true", then the address is more than likely invalid. notify the user and allow them to override if they so desire (as DNS takes a day or so to propogate through the net, so newly registered domains may not resolve immediately).
use getdnsrr for this ( http://www.php.net/getdnsrr )

Nuke Soldier Joined: Jan 25, 2004 Posts: 10

chican0 and friends

I am trying to make this change but it dont work.

I am using 7.0 and would like someone could send modules/Reccomend_us/index.php via email or URL to download.

I made so many changes in it that it dont works anyway, now.

Sorry bad English.

Thanks

Posted: Sun Jan 25, 2004 4:20 am

Code:

<?php

/************************************************************************/
/* PHP-NUKE: Web Portal System */
/* =========================== */
/* */
/* Copyright (c) 2002 by Francisco Burzi */
/* http://phpnuke.org */
/* */
/* This program is free software. You can redistribute it and/or modify */
/* it under the terms of the GNU General Public License as published by */
/* the Free Software Foundation; either version 2 of the License. */
/************************************************************************/

if (!eregi("modules.php", $_SERVER['PHP_SELF'])) {
die ("You can't access this file directly...");
}
require_once("mainfile.php");
$module_name = basename(dirname(__FILE__));
get_lang($module_name);
$pagetitle = "- "._RECOMMEND."";

function emailCheck($fmail) {
global $stop;
$item = explode("@", $fmail);
$domain = $item["1"];
if ((strlen($domain) >= 3) && (substr($domain, 0, 4) == 'www.')) $stop = "<center>ERROR: Please remove the www. from the domain section of your email address.</center>";
if ((strlen($fmail) >= 4) && (substr($fmail, 0, 4) == 'www.')) $stop = "<center>ERROR: Email addresses do not start with www.</center> ";
if ((!$fmail) || ($fmail=="") || (!eregi("^[_\.0-9a-z-]+@([0-9a-z][0-9a-z-]+\.)+[a-z]{2,6}$",$fmail))) $stop = "<center>ERROR: Invalid email address.</center> ";
if (strrpos($fmail,' ') > 0) $stop = "<center>Please remove spaces from email address.</center> ";
return($stop);
}

function RecommendSite() {
global $user, $cookie, $prefix, $dbi, $user_prefix, $module_name;
include ("header.php");
title(""._RECOMMEND."");
OpenTable();
echo "<center>"._RECOMMEND."</center> "
."<form action=\"modules.php?name=$module_name\" method=\"post\">"
."<input type=\"hidden\" name=\"op\" value=\"SendSite\">";
if (is_user($user)) {
$result=sql_query("select username, user_email from ".$user_prefix."_users where username='$cookie[1]'", $dbi);
list($yn, $ye) = sql_fetch_row($result, $dbi);
}
echo ""._FYOURNAME." <input type=\"text\" name=\"yname\" value=\"$yn\"> \n"
.""._FYOUREMAIL." <input type=\"text\" name=\"ymail\" value=\"$ye\"> \n"
.""._FFRIENDNAME." <input type=\"text\" name=\"fname\"> \n"
.""._FFRIENDEMAIL." <input type=\"text\" name=\"fmail\"> \n"
."<input type=submit value="._SEND.">\n"
."</form>\n";
CloseTable();
include ('footer.php');
}

function SendSite($yname, $ymail, $fname, $fmail) {
global $stop, $sitename, $slogan, $nukeurl, $module_name;
$fname = removecrlf($fname);
$fmail = removecrlf($fmail);
$yname = removecrlf($yname);
$ymail = removecrlf($ymail);
$subject = ""._INTSITE." $sitename";
$message = ""._HELLO." $fname:\n\n"._YOURFRIEND." $yname "._OURSITE." $sitename "._INTSENT."\n\n\n"._FSITENAME." $sitename\n$slogan\n"._FSITEURL." $nukeurl\n";
emailCheck($fmail);
if ($stop) {
include("header.php");
OpenTable();
echo "<center>Input Error! ";
echo "$stop "._GOBACK."</center>";
CloseTable();
include("footer.php");
} else {
mail($fmail, $subject, $message, "From: \"$yname\" <$ymail>\nX-Mailer: PHP/" . phpversion());
update_points(3);
Header("Location: modules.php?name=$module_name&op=SiteSent&fname=$fname");
}
}

function SiteSent($fname) {
include ('header.php');
OpenTable();
echo "<center>"._FREFERENCE." $fname... "._THANKSREC."</center>";
CloseTable();
include ('footer.php');
}

switch($op) {

case "SendSite":
SendSite($yname, $ymail, $fname, $fmail);
break;

case "SiteSent":
SiteSent($fname);
break;

default:
RecommendSite();
break;

}

?>

Just cut-n-paste that.

Nuke Soldier Joined: Jan 25, 2004 Posts: 10

Great chican0

Now its working fine.

purasorte