NSN News module - need links to open in new browser

Private Joined: Nov 12, 2006 Posts: 39

Hi wondered if someone could help me out.

Im using the NSN news module on my site, but have encountered a small hitch.

We are a pc hardware review site and so have lots of web news and affiliate news to post, usually this takes form as a small image + news title + plus little info then and clickable link which takes people directly to the news in question.

this works fine appart from the fact that the link opens the page in the same window - taking people away from my site (who wants to hit the back button 50 times to get back to my site?)

what i want to do is have the link open in a new window - sounds simple?
not in the case of nsn news module. for some reason it is cancelling out the fact i want it to do this.

here is the code im using:

Code:

<img src="image url goes in here" align="left"> Product name in here
a bit of info here...
<a href="review url address" target="_blank">Full News @ site name here</a>

In the nsn news admin configuration it has a list of allowed html tags:

Code:

b=>1
i=>1
a=>2
em=>1
br=>1
strong=>1
blockquote=>1
tt=>1
li=>1
ol=>1
ul=>1
p=>1
hr=>1
align=>2
img=>2

i have tried just about everything i can think of when it comes to the target_blank code

ive tried:

Code:

target="_blank"=>1
target="_blank"=>2
target=>1
target=>2

anybody have any ideas?
thanks

Private Joined: Nov 12, 2006 Posts: 39

Anyone?

Site Admin Joined: Aug 17, 2003 Posts: 12389

In mainfile.php

Code:

DELETE

$str = eregi_replace("<a[^>]*href[[:space:]]*=[[:space:]]*\"?[[:space:]]*([^\" >]*)[[:space:]]*\"?[^>]*>",'<a href="\\1">', $str);

Private Joined: Nov 12, 2006 Posts: 39

Hi thanks for the reply
I have looked in my mainfile.php in nuke root
and the only code i can find that reswembles the code you said i had to delete is:

Code:

function check_html ($str, $strip="") {
/* The core of this code has been lifted from phpslash */
/* which is licenced under the GPL. */
include("config.php");
if ($strip == "nohtml") $AllowableHTML = array('');
$str = eregi_replace("<[[:space:]]*([^>]*)[[:space:]]*>",'<\\1>', $str);
// Delete all spaces from html tags .
// Delete all attribs from Anchor, except an href, double quoted.
$str = eregi_replace("<[[:space:]]* img[[:space:]]*([^>]*)[[:space:]]*>", '', $str);
// Delete all img tags
$str = eregi_replace("<a[^>]*href[[:space:]]*=[[:space:]]*\"?javascript[[:punct:]]*\"?[^>]*>", '', $str);
// Delete javascript code from a href tags -- Zhen-Xjell @ http://nukecops.com
$tmp = "";
while (ereg("<(/?[[:alpha:]]*)[[:space:]]*([^>]*)>",$str,$reg)) {
 $i = strpos($str,$reg[0]);
 $l = strlen($reg[0]);
 if ($reg[1][0] == "/") $tag = strtolower(substr($reg[1],1));
 else $tag = strtolower($reg[1]);
 if ($a = (isset($AllowableHTML[$tag])) ? $AllowableHTML[$tag] : 0)
 if ($reg[1][0] == "/") $tag = "</$tag>";
 elseif (($a == 1) || (empty($reg[2]))) $tag = "<$tag>";
 else {
 # Place here the double quote fix function.
 $attrb_list=delQuotes($reg[2]);
 // A VER
$attrb_list = str_replace("&","&",$attrb_list);
 $attrb_list = str_replace("&","&",$attrb_list);
 $tag = "<$tag" . $attrb_list . ">";
 } # Attribs in tag allowed
 else $tag = "";
 $tmp .= substr($str,0,$i) . $tag;
 $str = substr($str,$i+$l);
}
$str = $tmp . $str;
$str = str_replace(" ", " ", $str);
return $str;
exit;
/* Squash PHP tags unconditionally */
$str = str_replace("<?","",$str);
return $str;

I cannot find anything else within the mainfile.php which matches what you wrote.

Site Admin Joined: Aug 17, 2003 Posts: 12389

Looks like it was already removed.
What version of phpNuke are you using?

Private Joined: Nov 12, 2006 Posts: 39

im using patched nuke 7.9

Private Joined: Nov 12, 2006 Posts: 39

can anybody help with this?

Nuke Cadet Joined: Jan 21, 2007 Posts: 4

Evaders99 wrote:

In mainfile.php

Code:

DELETE

$str = eregi_replace("<a[^>]*href[[:space:]]*=[[:space:]]*\"?[[:space:]]*([^\" >]*)[[:space:]]*\"?[^>]*>",'<a href="\\1">', $str);

not in the mainfile!!
you must uncomment this line in the nsnne_func.php. this file was locatet in the includes folder of your phpnuke-root.

open includes/nsnne_func.php search in the near of line 81 for:

Code:

function ne_check_html($str, $strip=0) {

in this function search in the near of line 90 for:

Code:

$str = eregi_replace("<a[^>]*href[[:space:]]*=[[:space:]]*\"?[[:space:]]*([^\" >]*)[[:space:]]*\"?[^>]*>",'<a href="\\1">', $str);

and now uncomment or delete this line:

Code:

//$str = eregi_replace("<a[^>]*href[[:space:]]*=[[:space:]]*\"?[[:space:]]*([^\" >]*)[[:space:]]*\"?[^>]*>",'<a href="\\1">', $str);

Problem fixit Wink