can't add/edit categories in the news module

Nuke Cadet Joined: Aug 07, 2005 Posts: 7

ok I have 7.7 installed with patch 3 and i recently installed sentinal. For some reason I can't add or edit categories. It says "this category already exists". not sure whats going on.

I read a post in regards to 7.0 that says that you have to edit admin/modules/stories.php which is not there. I did look at modules/news/admin/index.php not sure if this is what I need to edit but the code looks similar. here's the code

Quote:

Thanks in advance for any help

Posted: Fri Sep 02, 2005 11:09 pm

I have just discovered what appears to be a bug in the News module. I discovered this in a Nuke 7.7 patched 3.1 site but it may exist in an unpatched version. When you try to add a category the bug causes the category to be saved as News and not the category you tried to add. So when you next try to add another category, it again tries to save it as News (but that already exists because that is what the last category was saved as) and so it tells you that the category already exists.

The Bug will also cause any changes to the Category title to be saved as News when editing a category.

Here is an example of the bug at work when you try to add a category.

Right at the beginning of modules/News/admin/index.php you will find the following:

Code:

$query = $db->sql_query("SELECT title, admins FROM ".$prefix."_modules WHERE title='$module_name'");
list($title, $admins) = $db->sql_fetchrow($query);

This assigns the value News to $title and no matter which value of $title was passed to index.php, it will be reassigned the value News.

When we add a category the name of the Title field for the category is title thus:

Code:

."<input type=\"text\" name=\"title\" size=\"22\" maxlength=\"20\"> "

So the Title is passed as $title and is immediately assigned a new value News.

This can be fixed as follows (I have only done this for Adding a category, but similar changes can be made when editing a category too)

In modules/News/admin/index.php find

Code:

function AddCategory () {
   global $admin_file;
   include ("header.php");
   GraphicAdmin();
   OpenTable();
   echo "<center><font class=\"title\"><b>"._CATEGORIESADMIN."</b></font></center>";
   CloseTable();
   echo "<br>";
   OpenTable();
   echo "<center><font class=\"option\"><b>"._CATEGORYADD."</b></font><br><br><br>"
   ."<form action=\"".$admin_file.".php\" method=\"post\">"
   ."<b>"._CATNAME.":</b> "
   ."<input type=\"text\" name=\"title\" size=\"22\" maxlength=\"20\"> "
   ."<input type=\"hidden\" name=\"op\" value=\"SaveCategory\">"
   ."<input type=\"submit\" value=\""._SAVE."\">"
   ."</form></center>";
   CloseTable();
   include("footer.php");
}

and change to:

Code:

function AddCategory () {
   global $admin_file;
   include ("header.php");
   GraphicAdmin();
   OpenTable();
   echo "<center><font class=\"title\"><b>"._CATEGORIESADMIN."</b></font></center>";
   CloseTable();
   echo "<br>";
   OpenTable();
   echo "<center><font class=\"option\"><b>"._CATEGORYADD."</b></font><br><br><br>"
   ."<form action=\"".$admin_file.".php\" method=\"post\">"
   ."<b>"._CATNAME.":</b> "
   ."<input type=\"text\" name=\"ctitle\" size=\"22\" maxlength=\"20\"> "
   ."<input type=\"hidden\" name=\"op\" value=\"SaveCategory\">"
   ."<input type=\"submit\" value=\""._SAVE."\">"
   ."</form></center>";
   CloseTable();
   include("footer.php");
}

Above, I have changed the name of the _CATNAME field from title to ctitle.

Next find:

Code:

function SaveCategory($title) {
   global $prefix, $db;
   $title = ereg_replace("\"","",$title);
   $result = $db->sql_query("select catid from ".$prefix."_stories_cat where title='$title'");
   $check = $db->sql_numrows($result);
   if ($check) {
      $what1 = _CATEXISTS;
      $what2 = _GOBACK;
   } else {
      $what1 = _CATADDED;
      $what2 = _GOTOADMIN;
      $result = $db->sql_query("insert into ".$prefix."_stories_cat values (NULL, '$title', '0')");

and change to:

Code:

function SaveCategory($ctitle) {
   global $prefix, $db;
   $ctitle = ereg_replace("\"","",$ctitle);
   $result = $db->sql_query("select catid from ".$prefix."_stories_cat where title='$ctitle'");
   $check = $db->sql_numrows($result);
   if ($check) {
      $what1 = _CATEXISTS;
      $what2 = _GOBACK;
   } else {
      $what1 = _CATADDED;
      $what2 = _GOTOADMIN;
      $result = $db->sql_query("insert into ".$prefix."_stories_cat values (NULL, '$ctitle', '0')");

Above I have replaced all instances of $title with $ctitle.

Next find:

Code:

   case "SaveCategory":
   SaveCategory($title);
   break;

and change to:

Code:

   case "SaveCategory":
   SaveCategory($ctitle);
   break;

This will fix the bug when adding categories. Similar changes need to be made when editing categories too.

Site Admin Joined: Aug 17, 2003 Posts: 12397

Thanxs for the report - second confirmation of this problem
Hope we'll release a fixed version in the next Patched

Nuke Soldier Joined: Apr 07, 2004 Posts: 27

how can i then select a specific category to show in the news homepage.