[FIX] Wrong url after forum search for "redirect"

Private Joined: Feb 26, 2003 Posts: 48

This "bug" isn't only in the new port but also in the phpbb 2.1, I found it by accident but it is easy to "fix" , it isn't a pretty fix but it works. You can try it on any intergrated phpbb board and you will get the same result. When you search for "redirect" you will all the topics or posts (depends on what you have selected) all the results will bring you (when you click on one of them) to http://www.yourdomain.com/viewtopic?t=201&highlight=redirect (i took the example the result of http:.//www.nukefixes.com). All boards are effected by this (execpt the one on http://www.portedmods.com). To fix it open modules/Forums/search.php and search for the code :

Code:

$forum_url = append_sid("viewforum.$phpEx?" . POST_FORUM_URL . '=' . $searchset[$i]['forum_id']);
$topic_url = append_sid("viewtopic.$phpEx?" . POST_TOPIC_URL . '=' . $searchset[$i]['topic_id'] . "&highlight=$highlight_active");
$post_url = append_sid("viewtopic.$phpEx?" . POST_POST_URL . '=' . $searchset[$i]['post_id'] . "&highlight=$highlight_active") . '#' . $searchset[$i]['post_id'];

and replace the code with
Code:

Code:

$forum_url = "modules.php?name=Forums&file=viewforum&" . POST_FORUM_URL . '=' . $searchset[$i]['forum_id'];
$topic_url = "modules.php?name=Forums&file=viewtopic&" . POST_TOPIC_URL . '=' . $searchset[$i]['topic_id'] . "&highlight=$highlight_active";
$post_url = "modules.php?name=Forums&file=viewtopic&" . POST_POST_URL . '=' . $searchset[$i]['post_id'] . "&highlight=$highlight_active" . '#' . $searchset[$i]['post_id'];

All that was needed was removing the append_sid() command and the .$phpEx? and add modules.php?name=Forums&file= and after viewtopic or viewforum the & symbol. Like i said this is just the quick and dirty fix but it does work, try it your self I will post this on as many sites as possible.