Really strange GT Problem, need help please

Private Joined: Nov 07, 2003 Posts: 37

I have recently incorporated mreviews into my nuke site and tap setup,

I thought all was working fine then users start reporting issues, it seems that something in the mreviews tap code is interfering with the standard reviews tap code as anything that is prefaced by reviews.html is automatically set to reviews.html at the beginning regardless of whether it matches any of the other tap lines, i.e.

Code:

reviews.html - reviews.html (Correct)
reviews.html&op=showcontent&id=2 - reviews.html&op=showcontent&id=2 (Wrong) should actually be reviews-2.html !!!!

EDIT: I tried to enter modules.php ? name=Reviews above as the beginning of the code snippets but it keeps coming up in the post as reviews.html, must be the url rewrite in operation Smile

Can anyone please take a look at my .htacess snippets and header.php to see if they can see what is wrong ??

Header.php

Code:

$urlin = array(
"'(?<!/)modules.php\?name=News&file=article&sid=([0-9]*)&mode=([a-z]*)&order=([0-9]*)&thold=([0-9]*)'",
"'(?<!/)modules.php\?name=News&file=article&sid=([0-9]*)'",
"'(?<!/)modules.php\?name=News&file=article&sid=([0-9]*)'",
"'(?<!/)modules.php\?name=News&new_topic=([0-9]*)'",
"'(?<!/)modules.php\?name=Stories_Archive&sa=show_month&year=([0-9]*)&month=([0-9]*)&month_l=([a-zA-Z]*)'",
"'(?<!/)modules.php\?name=Stories_Archive'",
"'(?<!/)modules.php\?name=Downloads&d_op=getit&lid=([0-9]*)'",
"'(?<!/)modules.php\?name=Downloads&d_op=viewdownload&cid=([0-9]*)&min=([0-9]*)&orderby=titleA&show=([0-9]*)'",
"'(?<!/)modules.php\?name=Downloads&d_op=viewdownload&cid=([0-9]*)'",
"'(?<!/)modules.php\?name=Downloads&d_op=viewdownloaddetails&lid=([0-9]*)&ttitle=([/:\-\'{}()._&a-zA-Z0-9+= ]*)'",
"'(?<!/)modules.php\?name=(Downloads\")'",
"'(?<!/)modules.php\?name=MReviews&op=list_revs&cid=([0-9]*)&orderby=(sub-catA|sub-catZ|titleA|titleD|DateA|DateD|ScoreA|ScoreD|HitsA|HitsD)'",
"'(?<!/)modules.php\?name=MReviews&op=list_revs&cid=([0-9]*)&page=([0-9]*)'",
"'(?<!/)modules.php\?name=MReviews&op=list_revs&cid=([0-9]*)'",
"'(?<!/)modules.php\?name=MReviews&op=show&rid=([0-9]*)&page=([0-9]*)'",
"'(?<!/)modules.php\?name=MReviews&op=show&rid=([0-9]*)'",
"'(?<!/)modules.php\?name=MReviews&op=([a-zA-Z0-9+]*)&cid=([0-9]*)'",
"'(?<!/)modules.php\?name=MReviews&op=write_MReview'",
"'(?<!/)modules.php\?name=MReviews&file=friend&op=FriendSend&rid=([0-9]*)'",
"'(?<!/)modules.php\?name=MReviews&file=print&op=PrintPage&rid=([0-9]*)'",
"'(?<!/)modules.php\?name=MReviews&op=postcomment&rid=([0-9]*)'",
"'(?<!/)modules.php\?name=MReviews'",
"'(?<!/)modules.php\?name=Reviews&rop=showcontent&id=([0-9]*)'",
"'(?<!/)modules.php\?name=Reviews&rop=write_review'",
"'(?<!/)modules.php\?name=Reviews&rop=postcomment&id=([0-9]*)&title=([a-zA-Z0-9+]*)'",
"'(?<!/)modules.php\?name=Reviews&rop=mod_review&id=([0-9]*)'",
"'(?<!/)modules.php\?name=Reviews&rop=del_review&id_del=([0-9]*)'",
"'(?<!/)modules.php\?name=Reviews&rop=([a-zA-Z0-9]*)'",
"'(?<!/)modules.php\?name=Reviews'",
"'(?<!/)modules.php\?name=Submit_News'",
"'(?<!/)modules.php\?name=Topics'",
"'(?<!/)modules.php\?name=Top&zx=([a-zA-Z0-9+]*)'",
"'(?<!/)modules.php\?name=Top'",
"'(?<!/)modules.php\?name=FAQ&myfaq=yes&id_cat=([0-9]*)&categories=([a-zA-Z0-9+]*)'",
"'(?<!/)modules.php\?name=FAQ'",
"'(?<!/)modules.php\?name=Forums&file=viewtopic&t=([0-9]+)&postdays=([0-9]+)&postorder=asc&start=([0-9]+)'",
"'(?<!/)modules.php\?name=Forums&file=viewtopic&t=([0-9]*)&view=(next|previous)'",
"'(?<!/)modules.php\?name=Forums&file=viewforum&f=([0-9]+)&topicdays=([0-9]+)&start=([0-9]+)'",
"'(?<!/)modules.php\?name=Content&pa=showpage&pid=([0-9]*)'",
"'(?<!/)modules.php\?name=Content&pa=list_pages_categories&cid=([0-9]*)'",
"'(?<!/)modules.php\?name=Forums&file=viewforum&f=([0-9]*)&mark=topics'",
"'(?<!/)modules.php\?name=Forums&file=viewforum&f=([0-9]*)'",
"'(?<!/)modules.php\?name=Forums&file=viewtopic&t=([0-9]*)&view=newest'",
"'(?<!/)modules.php\?name=Forums&file=viewtopic&t=([0-9]*)&start=([0-9]*)'",
"'(?<!/)modules.php\?name=Forums&file=viewtopic&t=([0-9]*)&highlight=([/:\-\'(){}.&=_a-zA-Z0-9+[:space:]]*)'",
"'(?<!/)modules.php\?name=Forums&file=posting&t=([0-9]*)'",
"'(?<!/)modules.php\?name=Forums&file=index&mark=forums'",
"'(?<!/)modules.php\?name=Forums&file=viewtopic&(p|t)=([0-9]*)'",
"'(?<!/)modules.php\?name=Forums&file=index&c=([0-9]*)'",
"'(?<!/)modules.php\?name=Forums&file=index'",
"'(?<!/)modules.php\?name=Sections&op=(printpage|viewarticle)&artid=([0-9]*)'",
"'(?<!/)modules.php\?name=Sections&op=listarticles&secid=([0-9]*)'",
"'(?<!/)modules.php\?name=Sections'",
"'(?<!/)modules.php\?name=Your_Account&op=userinfo&username=([a-zA-Z0-9_-]*)'",
"'(?<!/)modules.php\?name=Your_Account&op=userinfo&username=([a-zA-Z0-9_-]*)'",
"'(?<!/)modules.php\?name=Web_Links&l_op=NewLinksDate&selectdate=([0-9]+)'",
"'(?<!/)modules.php\?name=Web_Links&l_op=(AddLink|MostPopular|NewLinks|RandomLink|TopRated)'",
"'(?<!/)modules.php\?name=Web_Links&l_op=ratelink&lid=([0-9]*)&ttitle=([/:\-\'(){}.&=_a-zA-Z0-9 ]*)'",
"'(?<!/)modules.php\?name=Web_Links&l_op=visit&lid=([0-9]*)'",
"'(?<!/)modules.php\?name=Web_Links&l_op=viewlink&cid=([0-9]*)&min=([0-9]*)&orderby=titleA&show=([0-9]*)'",
"'(?<!/)modules.php\?name=Web_Links&l_op=viewlink&cid=([0-9]*)'",
"'(?<!/)modules.php\?name=Web_Links&l_op=search&query=([a-zA-Z0-9_-]*)'",
"'(?<!/)modules.php\?name=Web_Links'",
);

$urlout = array(
"article-\\1-\\2-\\3-\\4.html",
"article\\1.html",
"article\\1.html",
"article-topic-\\1.html",
"archive-\\1-\\2-\\3.html",
"archive.html",
"downloads-file-\\1.html",
"downloads-cats-\\1-\\2-\\3.html",
"downloads-cat-\\1.html",
"downloads-file-\\1-details-\\2.html",
"downloads.html\"",
"mreviews-cat-\\1-order-\\2.html",
"mreviews-cat-\\1-\\2.html",
"mreviews-cat-\\1.html",
"mreview\\1-\\2.html",
"mreview\\1.html",
"mreviews-\\1-\\2.html",
"mreview-new.html",
"mreview-send-\\1.html",
"mreview-print-\\1.html",
"mreview_comment-\\1.html",
"mreviews.html",
"reviews-\\1.html",
"reviews-new.html",
"reviews-comment-\\1-\\2",
"reviews-\\1-edit.html",
"reviews-\\1-delete.html",
"reviews-sortby-\\1.html",
"reviews.html",
"submit.html",
"topics.html",
"top-\\1.html",
"top.html",
"faq-\\1-\\2.html",
"faq.html",
"postx\\1-\\2-\\3.html",
"to-\\2-\\1.html",
"forumx\\1-\\2-\\3.html",
"contentid-\\1.html",
"content-cat-\\1.html",
"markread\\1.html",
"forum\\1.html",
"newposts\\1.html",
"posts\\1-\\2.html",
"postlite\\1-\\2.html",
"fvote\\1.html",
"mark.html",
"post\\1\\2.html",
"forum-cat\\1.html",
"forums.html",
"section-\\1-\\2.html",
"section-\\1.html",
"sections.html",
"userinfo-\\1.html",
"userinfo-\\1.html",
"linksnew-\\1.html",
"linkop-\\1.html",
"ratelink-\\1-\\2.html",
"viewlink-\\1.html",
"links-\\1-\\2-\\3.html",
"link-\\1.html",
"searchlink\\1.html",
"links.html"
);

.htacess

Code:

#Articles
RewriteRule ^article-([0-9]*)-([a-z]*)-([0-9]*)-([0-9]*).html article.html$1&mode=$2&order=$3&thold=$4
RewriteRule ^article([1-9][0-9]*).* article.html$1
RewriteRule ^article-topic-([0-9]*).html article-topic-.html$1
RewriteRule ^allnews.html modules.php?name=News&file=allindex

#Content
RewriteRule ^contentid-([1-9][0-9]*).html contentid-.html$1
RewriteRule ^content-cat-([1-9][0-9]*).html content-cat-.html$1

#FAQ
RewriteRule ^faq.html faq.html
RewriteRule ^faq-([0-9]*)-([a-zA-Z0-9+]*).html faq.html&myfaq=yes&id_cat=$1&categories=$2

#Forums
RewriteRule ^forums.html modules.php?name=Forums
RewriteRule ^forums.* modules.php?name=Forums&file=index
RewriteRule ^forum-cat([0-9]*).html modules.php?name=Forums&c=$1
RewriteRule ^mark.html modules.php?name=Forums&file=index&mark=forums
RewriteRule ^postpoll([0-9]*).html modules.php?name=Forums&file=posting&t=$1
RewriteRule ^forumx([0-9]+)-([0-9]+)-([0-9]+).html modules.php?name=Forums&file=viewforum&f=$1&topicdays=$2&start=$3
RewriteRule ^to-(next|previous)-([0-9]*).html modules.php?name=Forums&file=viewtopic&t=$2&view=$1
RewriteRule ^postlite([0-9]*)-([[:punct:]/:\-\'(){}.&=_a-zA-Z0-9\ ]*).html modules.php?name=Forums&file=viewtopic&t=$1&highlight=$2
RewriteRule ^forum([1-9][0-9]*).* modules.php?name=Forums&file=viewforum&f=$1
RewriteRule ^posts([0-9]*)-([0-9]*).html modules.php?name=Forums&file=viewtopic&t=$1&start=$2
RewriteRule ^postx([0-9]+)-([0-9]+)-([0-9]+).html modules.php?name=Forums&file=viewtopic&t=$1&postdays=$2&postorder=asc&start=$3
RewriteRule ^post(p|t)([1-9][0-9]*).* modules.php?name=Forums&file=viewtopic&$1=$2
RewriteRule ^markread([0-9]*).html modules.php?name=Forums&file=viewforum&f=$1&mark=topics
RewriteRule ^newposts([0-9]*).html modules.php?name=Forums&file=viewtopic&t=$1&view=newest
RewriteRule ^fvote([0-9]*).html modules.php?name=Forums&file=posting&mode=vote&t=$1

#Downloads
RewriteRule ^downloads.html modules.php?name=Downloads
RewriteRule ^downloads-cat-([0-9]*).html&orderby=([a-zA-Z_]*) modules.php?name=Downloads&d_op=viewdownload&cid=$1&orderby=$2
RewriteRule ^downloads-cats-([0-9]*)-([0-9]*)-([0-9]*).html modules.php?name=Downloads&d_op=viewdownload&cid=$1&min=$2&orderby=titleA&show=$3
RewriteRule ^downloads-cat-([0-9]*).html modules.php?name=Downloads&d_op=viewdownload&cid=$1
RewriteRule ^downloads-file-([0-9]*)-details-([[:punct:]/:\-\'{}()._&a-zA-Z0-9+=]*).html modules.php?name=Downloads&d_op=viewdownloaddetails&lid=$1&ttitle=$2
RewriteRule ^downloads-file-([0-9]*).html modules.php?name=Downloads&d_op=getit&lid=$1

#MReviews
RewriteRule ^mreviews.html modules.php?name=MReviews
RewriteRule ^mreviews-cat-([0-9]*).html modules.php?name=MReviews&op=list_revs&cid=$1
RewriteRule ^mreviews-cat-([0-9]*)-([0-9]*).html modules.php?name=MReviews&op=list_revs&cid=$1&page=$2
RewriteRule ^mreview([0-9]*).html modules.php?name=MReviews&op=show&rid=$1
RewriteRule ^mreviews-([a-zA-Z0-9+]*)-([0-9]*).html modules.php?name=MReviews&op=$1&cid=$2
RewriteRule ^mreviews-cat-([0-9]*)-order-(sub-catA|sub-catZ|titleA|titleD|DateA|DateD|ScoreA|ScoreD|HitsA|HitsD).html modules.php?name=MReviews&op=list_revs&cid=$1&orderby=$2
RewriteRule ^mreview-new.html modules.php?name=MReviews&op=write_MReview
RewriteRule ^mreview-send-([0-9]*).html modules.php?name=MReviews&file=friend&op=FriendSend&rid=$1
RewriteRule ^mreview-print-([0-9]*).html modules.php?name=MReviews&file=print&op=PrintPage&rid=$1
RewriteRule ^mreview([0-9]*)-([0-9]*).html modules.php?name=MReviews&op=show&rid=$1&page=$2
RewriteRule ^mreview_comment-([0-9]*).html modules.php?name=MReviews&op=postcomment&rid=$1

#Stories Archive
RewriteRule ^archive.html archive.html
RewriteRule ^archive-([0-9]*)-([0-9]*)-([a-zA-Z]*).* archive.html&sa=show_month&year=$1&month=$2&month_l=$3

#Reviews
RewriteRule ^reviews.html reviews.html
RewriteRule ^reviews-([0-9]*).html reviews.html&rop=showcontent&id=$1
RewriteRule ^reviews-new.html reviews.html&rop=write_review
RewriteRule ^reviews-sortby-([a-zA-Z0-9]*).html reviews.html&rop=$1
RewriteRule ^reviews-comment-([0-9]*)-([[:punct:]a-zA-Z0-9]*).* reviews.html&rop=postcomment&id=$1&title=$2
RewriteRule ^reviews-([0-9]*)-delete.html reviews.html&rop=del_review&id_del=$1
RewriteRule ^reviews-([0-9]*)-edit.html reviews.html&rop=mod_review&id=$1

#Sections
RewriteRule ^section-(printpage|viewarticle)-([0-9]*).html sections.html&op=$1&artid=$2
RewriteRule ^section-([0-9]*).html sections.html&op=listarticles&secid=$1
RewriteRule ^sections.html sections.html

#Surveys
RewriteRule ^surveys.html modules.php?name=Surveys
RewriteRule ^survey([a-zA-Z0-9]*)results.html modules.php?name=Surveys&op=results&pollID=$1
RewriteRule ^survey([a-zA-Z0-9]*).html modules.php?name=Surveys&pollID=$1

#Submit
RewriteRule ^submit.html submit.html

#Search
#RewriteRule ^search.html modules.php?name=Search

#Top10
RewriteRule ^top-([[:print:]]*).html top.html&zx=$1
RewriteRule ^top.html top.html

#Topics
RewriteRule ^topics.html topics.html

#Your Account
RewriteRule ^userinfo-([a-zA-Z0-9_-]*).html userinfo-.html$1

#WebLinks
RewriteRule ^linksnew-([0-9]+).html modules.php?op=modload&name=Web_Links&file=index&l_op=NewLinksDate&selectdate=$1
RewriteRule ^linkop-(AddLink|MostPopular|NewLinks|RandomLink|TopRated).html modules.php?op=modload&name=Web_Links&file=index&l_op=$1
RewriteRule ^ratelink-([0-9]*)-([[:punct:]/:\-\'(){}.&=_a-zA-Z0-9\ ]*).html modules.php?op=modload&name=Web_Links&file=index&l_op=ratelink&lid=$1&ttitle=$2
RewriteRule ^viewlink-([0-9]*).html links.html&l_op=visit&lid=$1
RewriteRule ^links-([0-9]*)-([0-9]*)-([0-9]*).html links.html&file=index&l_op=viewlink&cid=$1&min=$2&orderby=titleA&show=$3
RewriteRule ^link-([0-9]*).html links.html&l_op=viewlink&cid=$1
RewriteRule ^searchlink([0-9]*).html links.html&l_op=search&query=$1
RewriteRule ^links.html links.html

Posted: Mon Jul 05, 2004 10:59 pm

Your header file looks fine. It's your .htaccess file that's wrong. Try this instead:

Code:

# Reviews
RewriteRule ^reviews.html reviews.html
RewriteRule ^reviews-([0-9]*).html reviews-sortby-showcontent.html&id=$1
RewriteRule ^reviews-new.html reviews-new.html
RewriteRule ^reviews-sortby-([a-zA-Z0-9]*).html reviews-sortby-.html$1
RewriteRule ^reviews-comment-([0-9]*)-([[:punct:]a-zA-Z0-9]*).* reviews-sortby-postcomment.html&id=$1&title=$2
RewriteRule ^reviews-([0-9]*)-delete.html reviews-sortby-del.html_review&id_del=$1
RewriteRule ^reviews-([0-9]*)-edit.html reviews-sortby-mod.html_review&id=$1

Private Joined: Nov 07, 2003 Posts: 37

nope that just stops it getting to the reviews at all with 404s.

cant understand why the reviews.html is being prepended when its the last statement, i thought googletap etc worked top to bottom, parsing the matching statements line by line in each file, in which case the lines should match up before the reviews.html matches !!!

can anyone help, its really frustrating

Posted: Tue Jul 06, 2004 7:41 pm

Err... I forgot that the nukecops forums use mod_rewrite so the code I pasted got rewritten (so will have any other example code posted in these forums so be warry when coping - any rewrite code copied from these forums will likely be wrong).

Here's a screenshot instead. Try this and see if it works:

Private Joined: Nov 07, 2003 Posts: 37

lol thats exactly the same as mine in the .htaccess the mod rewrite got y code as well !!!

have u got a mail address i can send my .htaccess and header.php to to take a look at ?

Posted: Wed Jul 07, 2004 7:31 pm

Sure. webmaster at belchfire.net Smile

Private Joined: Nov 07, 2003 Posts: 37

Ive emailed it on Hamesh Smile

and done the autoreply spam thing

Posted: Sat Jul 10, 2004 12:09 am

Check your email for my reply.

Private Joined: Nov 07, 2003 Posts: 37

I did the removal of the rops, but still no joy Hamesh !!!
I even removed the Mreviews section i had incorporated and it still like it !!!!

Its really doing my head in, anyone suggestions please, the problem is that reviews.html is substituted for modules.php ? name=Reviews all the time, before any other parsing occurs so therefore no matching of any lines occurs ?? (Spaces added in the line on purpose to thwart rewrite on forum)

Posted: Sat Jul 10, 2004 12:12 pm

Your site is http://www.motorhomefacts.com and your using nuke 6.9 right? Send me your ~/modules/Reviews/index.php file. I'm going by nuke 6.8 so the reviews module might have changed. I'll send you updated GTs based on the 6.9 reviews file.

Posted: Wed Jul 14, 2004 7:24 pm

I sent you a new set of rewrite rules based on your version of the Reviews module. Did you every try them? Just curious if they worked.