Wrong header redirect in search.php (2.0.6)

Nuke Cadet Joined: Dec 21, 2003 Posts: 6

Search.php contains 2 wrong redirects.

The will cause problems if a non logged on user tries to
- get the list of forums posts since the last visit (modules.php?name=Forums&file=search&search_id=newposts)
- do an ego search (modules.php?name=Forums&file=search&search_id=egosearch)

In both cases the user will get redirected to a page called login.php which does not exist in webroot (but in the modules/Forums dir!)

The fix:

OPEN UP modules/Forums/search.php

REPLACE LINE 216:

Code:

header("Location: login.$phpEx?redirect=search.$phpEx&search_id=newposts", true);

WITH:

Code:

$header_location = ( @preg_match("/Microsoft|WebSTAR|Xitami/", $_SERVER["SERVER_SOFTWARE"]) ) ? "Refresh: 0; URL=" : "Location: ";
header($header_location . append_sid("login.$phpEx?redirect=search.$phpEx&search_id=newposts", true));

REPLACE LINE 235:

Code:

header("Location: login.$phpEx?redirect=search.$phpEx&search_id=egosearch", true);

WITH:

Code:

$header_location = ( @preg_match("/Microsoft|WebSTAR|Xitami/", $_SERVER["SERVER_SOFTWARE"]) ) ? "Refresh: 0; URL=" : "Location: ";
header($header_location . append_sid("login.$phpEx?redirect=search.$phpEx&search_id=egosearch", true));