Hey all, I have seen a few things that are really starting to make me think of making a few of the core mods work differently, such as the reviews section and many of the others that pass the title in the URL. I say this because of the following example. Say you have a review and are passing the sid and title variable via the URL, so your title is
What?....I cant believe its not butter? Then your full URL will be
reviews-1(<--sid)-What?....I+cant+believe+its+not+butter?(<--title).html
When the variable is passed, since you are including .'s to be included for the title, the .html is passed as well to the function which displays what it was given, now your title is
"Do you want to rate What?....I+cant+believe+its+not+butter?.html"
To alleviate this, and the huge size of the URL, I would like to rewrite the code to only pass the ID and later sync the ID to the name in a db query, then display the name, this would only take a few entries per file probably, but help to go a long way in rewriting. Is this OK with everyone, and if so, is there ever a chance of changing the way a core module works in the distro? Idea's, Suggestions? Feedback? Back to bug fixes, later everyone.
I don't know about anyone else, but one of the reason I use GT is bcoz it doesn't make any changes to the core code of PHPNuke.
I use a default install of PHPNuke, with only small configurations. Then I install GT, which only add new function and make only a small modification to .php files.
Even with only such small changes, people already asking on how to install GT. Now, with code changes in the core files, how are we going to distribute the code? Are we going to put core files from various PHPNuke versions in the distribution files?
That is what my question is, what is the possibility if I do rewrite mods to not use the $title variable in the URL, getting that in the distro, if I cannot get a thumbs up from the community/developers on that, then I will not bother trying to do it.
The only way I would change core files and distribute them in the GT distro, is if it had the blessing to go in the distro, so everyone would remain on the same page of music. I clearly do not want there to be like downloadsGTmodule and etc, that opens a whole other can of worms. I agree with you, I want to apply GT with minimal changes to everything else, I also think that a change like this now could make a big difference in how short and cutesy the URL's look and prove beneficial in the future. Thanks for your feedback, I agree 100%.
Also, about people having all the questions, if you download the next distro update I think you will see many of the questions about mysterious GT will slowly fade. Can we say some documentation, Yeh!!!! I will probably put it up in the next hour.
There is a similar problem with the forums and the userinfo GT links. I haven't seen your code yet so I'm unsure if you addressed that. If not, its on my list to get done.
_________________ Paul Laudanski, Microsoft MVP Windows-Security
CastleCops: [de] [en] [wiki]
Audioslaved Elite Nuker
Joined: Jun 14, 2003
Posts: 420
Location: Hawaii and The Fan Forum
Posted:
Thu Oct 23, 2003 5:45 am
I may have addressed this problem in the current distribution of rewrites. I would be interested in hearing if the staff thinks the distribution is turning out OK. Alrighty, issue at hand.
If I was to change the way a few modules do the URL's, take out the passing of the $title variable and just leave the $sid, then process the sid with the title in the function, is there a way that type of thing could get added to the distro(s). I think this would be a good move because we will be able to cut out many conversions in the header.php and the URL's will stay short and sweet without affecting how the core of the module works.
You cannot post new topics in this forum You cannot reply to topics in this forum You cannot edit your posts in this forum You cannot delete your posts in this forum You cannot vote in polls in this forum
