Web Links and Download modules search typo

Lieutenant Joined: Mar 11, 2003 Posts: 180

when running a search in the Web Links or Downloads modules, if the download or link has any comments, a developer typo will throw off the rest of the page

this is the report that i submitted to bugs.nukecops.com:

Quote:

If you run a search in the Web Links module, the Comments link give the incorrect url, due to a typo on the part of the author.

Search for this code:

Code:

   if ($totalcomments != 0) {
   echo " | <a href=\"modules.php?name=".$module_name."&l_op=viewsitecomments&site_id=$site_id&ttitle=$transfertitle>"._SCOMMENTS." ($totalcomments)</a>";
   }

Replace with this code:

Code:

   if ($totalcomments != 0) {
   echo " | <a href=\"modules.php?name=".$module_name."&l_op=viewsitecomments&site_id=$site_id&ttitle=$transfertitle\">"._SCOMMENTS." ($totalcomments)</a>";
   }

Please note, the corrected code place a \" at the end of the url, which was missing before.

The same typo is in the default Downloads module in PHP Nuke 6.5 (tho slightly different code, of course). I'm not sure about later Download modules, since I use NS EDL for all of my post-6.5 sites.