User can't logoff properly (non-default theme) 7.7 Patch 3.0

Nuke Cadet Joined: Jun 03, 2005 Posts: 7

Hi,

When I install "Nuke 7.7 Patched 3.0" (on top of original PHP-Nuke 7.7 version of course), users with a non-default theme cannot logoff properly anymore.

For instance default theme = "DeepBlue" and a user chooses another theme "3DFantasy". When the user presses the logoff/exit button, the browser will go and stay blank with the following url in the address bar (http://path-to-nuke/modules.php?name=Your_Account&op=logout).
However, when you hit the refresh button in your browser (with the above url still in there) the user gets logged off after all.

Normally, the screen would refresh automatically and say "you are now logged out" before going to index.php automatically.

When the user switches back to the default theme, logoff works properly again.

Found a site with exactly the same problem here: http://demo.opensourcecms.com/phpnuke/index.php (login:admin pass:demo)

Could this be a bug in function logout() in modules/Your_Account/index.php or in header.php?

Fatal error: Cannot redeclare opentable() (previously declared in C:\path-to-nuke\themes\3D-Fantasy\tables.php:10) in C:\path-to-nuke\themes\DeepBlue\theme.php on line 10

My suggestion would be here, but I'm unsure.

Code:

How can I solve this little bug?

TIA, Anton!

Reproduced in this way:

- Install PHP-Nuke 7.7 and import nuke.sql
- Create admin account (admin)
- Create a user account (test)
- Copy over Nuke 7.7 Patched 3.0 on top and overwrite files
- Run upgrade.php
- Logoff the phpnuke admin account if logged in.
- Logon as a user and change your theme other than the default (in Your Account)
- Logoff user

Now your browser will go and stay blank until you refresh your window (F5)

Nuke Cadet Joined: Jun 03, 2005 Posts: 7

Please move this topic to "Bug Reports".

Posted: Sat Jun 04, 2005 10:01 am

Hm... I fixed the bug... Geezz.... i don't remember how I fixed it. My site is 7.7 and I fixed it. When I remember it, I will post it. the META tag is not the ultimate solution to fix it out.

Nuke Cadet Joined: Jun 03, 2005 Posts: 7

If you could post a solution that would be great! Cool

Just let me know if you remember how you fixed this.

Site Admin Joined: Aug 17, 2003 Posts: 12397

Make sure the theme.php file is called only once

Code:

include_once("themes/$themesel/$theme.php");

never just include()

Nuke Cadet Joined: Jun 03, 2005 Posts: 7

Hi Evaders99,

I wish it was that simple, but that trick doesn't work.

This is (among other things) inside of my theme.php of 3DFantasy:

Code:

if(file_exists("themes/3D-Fantasy/tables.php")){
include_once("themes/3D-Fantasy/tables.php");
}

This is (among other things) inside of my header.php

Code:

include_once("themes/$ThemeSel/theme.php");

Unluckily it occurs with every theme that is selected other than the default. Even when everything is set to include_once.

Without the Nuke patched version everything works just fine. It really seems a bug within Nuke Patched.

Maybe you have another idea of why this happens?

Nuke Cadet Joined: Jun 03, 2005 Posts: 7

Hi,

I think I solved the problem by commenting out

Code:

include_once("themes/$ThemeSel/theme.php");

in header.php.

So, now every theme works in Nuke Patched 3.0 too. Without problems.

Code:

Site Admin Joined: Aug 17, 2003 Posts: 12397

So weird.. that means head() must be called more than once somewhere?
I'm glad you found a solution, however awkward.

Edit: I see the problem, it is because mainfile.php also tries to include theme.php, twice!

Code:

if(!defined('FORUM_ADMIN')) {
$ThemeSel = get_theme();
include_once("themes/$ThemeSel/theme.php");
}

Why the include_once is not working as intended, I have no idea

Nuke Cadet Joined: Jun 03, 2005 Posts: 7

I'd also expect include_once to work as intended, but occasionally solutions to problems aren't straightforward (you probably know that better than I do). Cool

I'll see what is the difference between the original mainfile.php (+ header.php) and the Patched ones.

As I can reproduce it over and over (as described above) on different systems, it really seems a little but nasty bug.

Maybe chatserv can have a look at it, so other users won't experience the same problem in the future.

Thanks a million for your info!

Edit: well, I didn't test Evaders99's info yet BobMarion, so please don't blame me for that.

Nuke Soldier Joined: Feb 20, 2003 Posts: 17

You seem to misunderstand what mainfile is doing. It only includes the theme.php file if it isn't already loaded. Like other scripts have uncovered issues in the YA module this seems to be the case and I'm already looking at a solution which will be posted on my site once I find it.

Posted: Wed Jun 08, 2005 5:00 pm

Oh, Bob. you traveled too far away from your site. ha ha.

Nuke Soldier Joined: Feb 20, 2003 Posts: 17

As promised:
http://www.nukescripts.net/modules.php?name=News&file=article&sid=1719

Nuke Cadet Joined: Jun 03, 2005 Posts: 7

Bob, my intention was to report this bug and describe it in detail so anybody could reproduce it. Not just "I got this error, help me!"

I sincerely hope to get PHP-Nuke (Patched) better and more pleasant for users to use it. Any posts previously were just speculation on a possible solution and therefore you shouldn't blame me or Evaders99 for our efforts. Sometimes it is just trial-and-error.

However I'm very glad you are participating in this issue and willing to spend your precious time on possible solutions.

Greetings,
Anton

Private Joined: Jul 30, 2005 Posts: 35

hi,
i have the same problem and just looking for more info or solutions . . .

Any News?

Bye, thanx

Site Admin Joined: Aug 17, 2003 Posts: 12397

Try this fix
http://www.nukefixes.com/ftopict-1779.html
The latest one at the bottom of the first post

Tell me that works, I've tested and it seems to work for me